Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

Project and Repo not shown correctly in dropboxes in global admin GUI #238

Closed
BrianKrohn opened this issue Jul 30, 2017 · 12 comments
Closed
Labels

Comments

@BrianKrohn
Copy link

After upgrading to 3.6 from 3.1 of the add-on, all settings were lost and saving settings doesn't actually save anything. On Bitbucket 5.1.1.

@tomasbjerre
Copy link
Owner

Have a look at #116 . Some users are confused about having to press the dropdown to see the notifications.

@BrianKrohn
Copy link
Author

I got some clarification from the devs that reported this too me. In the Notification section, under Trigger, the Project and Repository dropdowns always say "Any". When you change them and click Save, they revert to "Any".

@tomasbjerre
Copy link
Owner

tomasbjerre commented Jul 30, 2017 via email

@BrianKrohn
Copy link
Author

Sorry. I am new to this. Where is the template?

@tomasbjerre
Copy link
Owner

Upgrading from Stash to BBS is not something that I will spend time on fixing. And probably not accept a PR for. There are very few users doing that now.

I cannot confirm that "saving settings doesn't actually save anything". I can confirm that the project and repo dropboxes dont get populated correctly. I also see an extra notification being created when I change the project.

@tomasbjerre tomasbjerre changed the title Settings lost and save no longer functions Project and Repo not shown correctly in dropboxes in global admin GUI Jul 30, 2017
@BrianKrohn
Copy link
Author

I'm not upgrading from Stash (going from BBS 4.8.4 to 5.1.1) so that's fine. The Project and Repo dropdowns change to "Any" when you attempt to update an existing Notification, so I think that fits your description.

There are no error messages or exceptions in the logs that I could find. I'd be happy to share anything you need. I can also replicate this on my test server, so if there's anything you want me to try, let me know.

@tomasbjerre
Copy link
Owner

I think this was introduced in 3.5. You may try 3.4 by downloading it from here: https://github.com/tomasbjerre/pull-request-notifier-for-bitbucket/releases I think that is the most recent version without this problem.

@tomasbjerre
Copy link
Owner

The project and repo settings should now be saved correctly. Released in 3.7. Was that all here or are you actually not able to save anything at all?

@BrianKrohn
Copy link
Author

My original issue was solved with your note about 116. That's when we found the Project and Repo dropdowns weren't saving when a Notification was updated. I just verified that your change fixed it. Thanks for the quick response and fix. I was not expecting it. I will try to follow your template next time, if we ever come across an issue. Thanks again.

@tomasbjerre
Copy link
Owner

Great no problem!

@annmcd
Copy link

annmcd commented Nov 30, 2017

Could you attach an example of saving a new or exsting notificaiton via rest api

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants