Merge pull request #398 from joeyparrish/fix-node-v12

fix: Fix test failures in node v4-v12
tomas · Apr 7, 2022 · b5cf883 · b5cf883
2 parents 33e834f + 64dfba1
commit b5cf883
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/needle.js b/lib/needle.js
@@ -542,12 +542,11 @@ Needle.prototype.send_request = function(count, method, uri, config, post_data,
     out.done = true;
 
     // An error can still be fired after closing.  In particular, on macOS.
-    // Adding an explicit abort() call resolves this without leaving a dangling
-    // listener.  See also:
+    // See also:
     //  - https://github.com/tomas/needle/issues/391
     //  - https://github.com/less/less.js/issues/3693
     //  - https://github.com/nodejs/node/issues/27916
-    request.abort();
+    request.once('error', function() {});
 
     if (callback)
       return callback(err, resp, resp ? resp.body : undefined);