raft: implements appendEntriesResponse #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMUKHA-PK
changed the title
SUMUKHA-PK
reviewed
May 19, 2020
There was a problem hiding this comment.
Im guessing you followed Figure 2 from https://raft.github.io/raft.pdf
Can you please add comments over the lines which do anything?
For example if nodeTerm > leaderTerm, you must write Reply false if term < currentTerm or something justifying it. Makes reviewing and reading later easier.
This kind of things are already mentioned in the design doc, that's why I didn't commented about that due to writing same thing two times. |
|
Yes but please do. |
SUMUKHA-PK
reviewed
May 22, 2020
SUMUKHA-PK
reviewed
May 22, 2020
tsatke
suggested changes
May 22, 2020
tsatke
suggested changes
May 25, 2020
tsatke
changed the title
SUMUKHA-PK
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When appendEntry RPC is sent by leader to other nodes, this function generate response for the leader and handles the entries that should be stored in node logs.