Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled launcher state is lost after upgrade and reenable #558

Closed
matteodelabre opened this issue Feb 21, 2022 · 0 comments · Fixed by #567
Closed

Enabled launcher state is lost after upgrade and reenable #558

matteodelabre opened this issue Feb 21, 2022 · 0 comments · Fixed by #567
Labels
bug Something isn't working install Installation scripts

Comments

@matteodelabre
Copy link
Member

matteodelabre commented Feb 21, 2022

In normal circumstances, when enabling a launcher app to start at boot, a symlink is created by systemd from /etc/systemd/system/launcher.service to the said service. This helps prevent having multiple launchers start at boot and compete for display access, and is used by Toltec’s helper how-to-enable to inform users that they need to disable another launcher before enabling a new one.

After upgrades, the systemd state gets overwritten as it’s located on the system partition. In particular, Xochitl reverts to its enabled state and the launcher.service symlink is not recreated, even after toltecctl reenable is run. This causes a state where both Xochitl and a launcher can be enabled simultaneously, and post-install messages after installing a launcher are incorrect.

@matteodelabre matteodelabre added bug Something isn't working install Installation scripts labels Feb 21, 2022
matteodelabre added a commit that referenced this issue Mar 5, 2022
This PR contains some fixes for the xochitl package:

* On configure, force creating the launcher.service symlink if Xochitl was previously enabled (closes #558). After removal, force cleaning the launcher.service if Xochitl is enabled.
* Remove unused dependency on `findutils`.
* Fix the following warning in `xochitl` wrapper script that would appear in Xochitl logs when there are no files in /opt/etc/xochitl.env.d (such as by default on rM1):

```
/opt/bin/xochitl: line 8: /opt/etc/xochitl.env.d/*.env: No such file or directory
```
@matteodelabre matteodelabre linked a pull request Mar 5, 2022 that will close this issue
matteodelabre added a commit that referenced this issue Mar 16, 2022
This PR contains some fixes for the xochitl package:

* On configure, force creating the launcher.service symlink if Xochitl was previously enabled (closes #558). After removal, force cleaning the launcher.service if Xochitl is enabled.
* Remove unused dependency on `findutils`.
* Fix the following warning in `xochitl` wrapper script that would appear in Xochitl logs when there are no files in /opt/etc/xochitl.env.d (such as by default on rM1):

```
/opt/bin/xochitl: line 8: /opt/etc/xochitl.env.d/*.env: No such file or directory
```
Eeems added a commit that referenced this issue Jul 12, 2022
New packages
----------------

- `linux-mainline` - 5.18.0-1 (#488)
  - Mainline linux kernel for the rM2 only

Updated packages
--------------------

* `koreader` - 2022.06-1 (#590 #599)
  - Fix reMarkable crash bug v2022.05: event overwrite with new time module
* `display` `rm2fb-client` - 1:0.0.20-1 (#592 #597 #604)
  - Added support for OS 2.13.0.758
  - Added support for OS 2.14.0.861
  - Added support for OS 2.14.1.866
* `ddvk-hacks` - 35.01-1 (#593 #598 #605)
  - Support OS 2.12.3.606 for rM1
  - Support OS 2.13.0.758 for rM2
  - Support OS 2.14.0.861 for both rM1 and rM2
  - Supprot OS 2.14.1.866 for both rM1 and rM2
* `folly` - 0.0.1-3 (#587)
* `remux` - 0.2.3-1 (#588)
  - Make palm filtering a config option
* `harmony` - 0.2.1-1 (#558)
  - More layer dialog improvements
  - Sort import dialog by file date
  - Refactor pressure / tilt events to use hardware values
* `wireguard` - 1.0.20210219-3 (#488)
  - Move to kernel section
* `fuse` - 1.0.0-4 (#488)
  - Move to kernel section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working install Installation scripts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant