Removed dependency on docker #21
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for calling `toltecmk` inside container. Builder now accepts a `source_dir` argument for using local sources (convenient to use during app development).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of #1 and fixes #13.
The
toltecmkscript runs locally, optionally using a provided source directory. It can be run inside a container with the image name specified in thepackagerecipe by callingtoltecmk-contained.As the toltec images are based on Debian buster, I recommend limiting the required python version to
3.7. This requires a single change in some typing logic. Ultimately, it would be nice to includetoltecmkin the base toltec image, so a build could be triggered with something like: