Upgrade xterm-addon-ligatures for WebGL support #11
Conversation
See discussions here for context: vercel/hyper#3607 (comment) xtermjs/xterm.js#3286 xtermjs/xterm.js#2847 vercel/hyper#5888
jacob-israel-turner
force-pushed
the
user/jacobt/add-webgl-support
branch
2 times, most recently
from
b965ed2
to
f910eb5
Compare
jacob-israel-turner
force-pushed
the
user/jacobt/add-webgl-support
branch
from
f910eb5
to
7d66ef3
Compare
|
@tolbertam let me know if you have a chance to review this! Happy to make any additional changes you want. |
|
As I'm playing with this again, I'm seeing more issues than I thought. Especially while using Vim. The WebGL + Ligature combination appears to be better than what's been released, but people should still be cautious when enabling both. |
|
@tolbertam do you have any interest in merging this PR? |
|
Came looking here when my Hyper + Hyper-Font-Ligatures + Fira Code + macOS Monterrey stopped working after my Monterrey upgrades (on 2 different MacBooks sharing the same .hyper.js configs). Wondering if merging this PR would fix my issue. |
|
@indygwyn mine also stopped working this morning after updating fira code via brew. In the end it seems that using font-firacode-nerd-font (iirc) instead was the true solution. |
|
@jacob-israel-turner Deepest apologies for not noticing this until now. Will try to find some time this week to review this and assuming it looks good i'll merge and release it! |
|
@tolbertam have you had a chance to look at this? |
|
Hey @tolbertam! Unfortunately I've switched from hyperterm to alacritty, so I won't be pursuing this PR anymore. Feel free to close or use whatever is salvageable. |
See discussions here for context:
vercel/hyper#3607 (comment)
xtermjs/xterm.js#3286
xtermjs/xterm.js#2847
vercel/hyper#5888
It should still be noted that there are some known issues with ligatures in WebGL (vercel/hyper#5757 and xtermjs/xterm.js#3303). However, it's my opinion that it's still worth using ligatures in WebGL. But users should know that enabling both may result in some rendering glitches.