Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply markdown lint and formatting #732

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Apply markdown lint and formatting #732

merged 1 commit into from
Nov 25, 2023

Conversation

barafael
Copy link
Contributor

IMHO, the markdown in this repo should be formatted and relatively free of lints, because that lowers the barrier of entry for contributions. Let me know what you think :)

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What linter is this? I've never used any markdown linters, so I'm not familiar with what linters exist.

content/tokio/glossary.md Outdated Show resolved Hide resolved
content/tokio/topics/bridging.md Outdated Show resolved Hide resolved
content/tokio/topics/bridging.md Outdated Show resolved Hide resolved
@barafael
Copy link
Contributor Author

The linter: https://github.com/DavidAnson/markdownlint but it is more opinionated than I thought. I'm resolving your comments.

Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I've now looked through every change and commented on those I disagree with.

content/tokio/glossary.md Outdated Show resolved Hide resolved
content/tokio/tutorial/hello-tokio.md Outdated Show resolved Hide resolved
content/tokio/tutorial/shared-state.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 6ee2e06 into tokio-rs:master Nov 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants