Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically creates PR when no_atomic.rs needs to be updated #90

Merged
merged 2 commits into from
Mar 7, 2022
Merged

Automatically creates PR when no_atomic.rs needs to be updated #90

merged 2 commits into from
Mar 7, 2022

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Mar 5, 2022 •
edited
Loading

This solves the following todo:

valuable/.github/workflows/ci.yml

Lines 75 to 77 in 1fc2ad5

# TODO(taiki-e): Ideally, this should be automated using a bot that creates
# PR when failed, but there is no bandwidth to implement it
# right now...

examples of auto-created PR: crossbeam-rs/crossbeam#793, taiki-e/portable-atomic#3

@taiki-e taiki-e requested a review from hawkw March 5, 2022 11:25
@taiki-e taiki-e mentioned this pull request Mar 5, 2022
Merged
hawkw
hawkw approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely, thank you!

@taiki-e taiki-e merged commit 662a983 into master Mar 7, 2022
@taiki-e taiki-e deleted the taiki-e/no-atomic branch March 7, 2022 03:24
@taiki-e taiki-e mentioned this pull request Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @hawkw