Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains two commits that fix MSRV issues.
attributes: remove use of non-MSRV-compliant
Option::flatten
PR #[instrument] - support use of the 'self' variable in async-trait contexts #875 added code to
tracing-attributes
that usesOption::flatten
, which was only added to the standard library inRust 1.40. This broke our MSRV, but we missed it because the MSRV CI
checks weren't working correctly (fixed in chore: correct the MSRV check #934).
This commit removes the use of
Option::flatten
, and replaces it witha manual implementation. It's a little less pretty, but it builds on
our MSRV (1.39.0).
Once this merges, we'll publish a new
tracing-attributes
version,and yank 0.1.10.
examples: disable
opentelemetry
's default featuresThe
opentelemetry
crate depends onprometheus
, which depends onprotobuf
, a crate which doesn't compile on our MSRV (Rust 1.39).This was missed due to issues with the MSRV CI checks, which will be
fixed fixed in chore: correct the MSRV check #934. Therefore, once the MSRV checks work properly,
the
protobuf
dependency will break our builds.We don't need the
opentelemetry/metrics
feature, which is whatenables the
prometheus
(and thusprotobuf
) dependency.tracing-opentelemetry
already has adefault-features = false
dependency on
opentelemetry
, but the examples don't. Therefore, I'vechanged the examples crate to disable
opentelemetry
's defaultfeatures as well.