Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for instrument(name) #897

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

anton-dutov
Copy link
Contributor

Motivation

Not found in documentation how to change generated span name name, only in sources, then i found issue #725

Solution

Documentation added

@anton-dutov anton-dutov requested review from hawkw and a team as code owners August 7, 2020 12:11
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you!

@hawkw hawkw merged commit ed28c1f into tokio-rs:master Aug 7, 2020
hawkw added a commit that referenced this pull request Aug 10, 2020
Added

- Support for using `self` in field expressions when instrumenting
  `async-trait` functions (#875)
- Several documentation improvements (#832, #897, #911, #913)

Thanks to @anton-dutov and @nightmared for contributing to this release!
hawkw added a commit that referenced this pull request Aug 10, 2020
### Added

- Support for using `self` in field expressions when instrumenting
  `async-trait` functions (#875)
- Several documentation improvements (#832, #897, #911, #913)

Thanks to @anton-dutov and @nightmared for contributing to this release!
hawkw added a commit that referenced this pull request Aug 10, 2020
Fixed

- Updated `tracing-core` to fix incorrect calculation of the global max
  level filter (#908)

Added

- **attributes**: Support for using `self` in field expressions when
  instrumenting `async-trait` functions (#875)
- Several documentation improvements (#832, #881, #896, #897, #911,
  #913)

Thanks to @anton-dutov, @nightmared, @mystor, and @toshokan for
contributing to  this release!
hawkw added a commit that referenced this pull request Aug 11, 2020
### Fixed

- Updated `tracing-core` to fix incorrect calculation of the global max
  level filter (#908)

### Added

- **attributes**: Support for using `self` in field expressions when
  instrumenting `async-trait` functions (#875)
- Several documentation improvements (#832, #881, #896, #897, #911,
  #913)

Thanks to @anton-dutov, @nightmared, @mystor, and @toshokan for
contributing to  this release!

Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants