fmt: add support for off filter directives
#72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added
kind/feature
Signed-off-by: Eliza Weisman <[email protected]>
|
Sorry I couldnt get to this earlier! but it looks good! |
hawkw
added a commit
that referenced
this pull request
Jun 21, 2019
PR #72 introduced a bug in `EnvFilter` where spans and events whose level is _equal_ to the filter's max level are rejected, rather than accepted. This branch fixes the comparisons so that filters once again work as expected. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 21, 2019
PR #72 introduced a bug in `EnvFilter` where spans and events whose level is _equal_ to the filter's max level are rejected, rather than accepted. This branch fixes the comparisons so that filters once again work as expected. Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
env_loggercrate allows log directives ending inofftodisable all logging from a matching target. However,
tokio-trace-fmt'sEnvFilterdoes not.For example:
env_loggeraccepts these directives.Solution
This branch adds support for directives with
off. It was necessary toreimplement a
LevelFiltertype, here similar to the one intokio-trace, astokio-trace-fmtonly depends ontokio-trace-core.Fixes: #68
Signed-off-by: Eliza Weisman [email protected]