chore: fix nightly ci #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent upstream change to `tokio-test` (tokio-rs/tokio#1728) removed the `MockTask` API in favour of a more ergonomic `task::spawn` API. This broke our tests for `tracing-futures` `std::future` compatibility, which depend on `tokio-test` from Git. This branch updates these tests to use the new API, which *is* much nicer. This should fix nightly CI. Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added
crate/attributes
LucioFranco
approved these changes
Nov 4, 2019
yaahc
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A recent upstream change to
tokio-test(tokio-rs/tokio#1728) removedthe
MockTaskAPI in favour of a more ergonomictask::spawnAPI. Thisbroke our tests for
tracing-futuresandtracing-attributesstd::futurecompatibility, which depend on
tokio-testfrom Git.Solution
This branch updates these tests to use the new API, which is much
nicer. This should fix nightly CI.
Signed-off-by: Eliza Weisman [email protected]