-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appender: add initial set of benches #2128
appender: add initial set of benches #2128
Conversation
This patch adds blocking and nonblocking benchmarks. This code is from an old PR (tokio-rs#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]>
Ran the benchmarks locally:
|
Ran these benchmarks on a slower, but less noisy, VM. Under the theory that the writers here where benchmarking the allocator more than
(The prior run was the PR's existing contents.) I'll flamegraph these benchmarks to confirm that it's allocator overhead, but I suspect that we'd want to change the writers to return only the buffer size to measure just |
Thanks. I need to look at why the Netlify build is failing... |
same reason it was failing in Tokio: tokio-rs/tokio#4699 (comment). I'll fix this. |
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: David Barsky <[email protected]>
* appender: add initial set of benches This patch adds blocking and nonblocking benchmarks. This code is from an old PR (#703) that was never merged, and now ported to TOT so that it compiles. Co-authored-by: Zeki Sherif <[email protected]> * switch to no-op writers in benchmarks * fix macro resolution issue Co-authored-by: Zeki Sherif <[email protected]> Co-authored-by: David Barsky <[email protected]>
This patch adds blocking and nonblocking benchmarks. This code is from
an old PR (#703) that was never merged, and now ported to TOT so that it
compiles.
Co-authored-by: Zeki Sherif [email protected]