Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically resolved metadata (normalized_metadata) in core #2048

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Dynamically resolved metadata (normalized_metadata) in core #2048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d4c8525
Add lifetime to field::Visit
CAD97 Apr 3, 2022
25d2f5e
Remove unsafety in tracing-log impl
CAD97 Apr 3, 2022
cba568c
Uplift trait RecordFields to tracing-core
CAD97 Apr 3, 2022
c001fea
Remove 'static requirement from Metadata::name
CAD97 Apr 3, 2022
6afe420
Make more things work with non-'static metadata
CAD97 Apr 3, 2022
72ab527
Implement dynamic metadata injection
CAD97 Apr 3, 2022
6d8bce1
Implement tracing-log on core dynamic metadata
CAD97 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/examples/counters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ struct Count<'a> {
counters: RwLockReadGuard<'a, HashMap<String, AtomicUsize>>,
}

impl<'a> Visit for Count<'a> {
impl<'a> Visit<'_> for Count<'a> {
fn record_i64(&mut self, field: &Field, value: i64) {
if let Some(counter) = self.counters.get(field.name()) {
if value > 0 {
Expand Down
4 changes: 2 additions & 2 deletions examples/examples/sloggish/sloggish_collector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,13 @@ impl Span {
}
}

impl Visit for Span {
impl Visit<'_> for Span {
fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug) {
self.kvs.push((field.name(), format!("{:?}", value)))
}
}

impl<'a> Visit for Event<'a> {
impl<'a> Visit<'_> for Event<'a> {
fn record_debug(&mut self, field: &Field, value: &dyn fmt::Debug) {
write!(
&mut self.stderr,
Expand Down
Loading