subscriber: fix Filtered::on_exit calling on_enter by mistake
#2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation Currently, the `Filtered` type's `Layer` impl accidentally calls the inner `Filter`'s `on_enter` hook in the `on_exit` hook. This is...obviously wrong, lol, and means that filters like `EnvFilter` will never consider spans to have exited, breaking filtering behavior. @tfreiberg-fastly originally noticed this bug (see #1983 (comment)), but I wanted to make the change separately from PR #1983 so that we can fix it on the main branch without waiting for #1983 to merge first. ## Solution This branch, uh, you know... fixes that.
hawkw
added a commit
that referenced
this pull request
Mar 29, 2022
) ## Motivation Currently, the `Filtered` type's `Subscribe` impl accidentally calls the inner `Filter`'s `on_enter` hook in the `on_exit` hook. This is...obviously wrong, lol, and means that filters like `EnvFilter` will never consider spans to have exited, breaking filtering behavior. @tfreiberg-fastly originally noticed this bug (see #1983 (comment)), but I wanted to make the change separately from PR #1983 so that we can fix it on the main branch without waiting for #1983 to merge first. ## Solution This branch, uh, you know... fixes that.
hawkw
added a commit
that referenced
this pull request
Mar 29, 2022
) ## Motivation Currently, the `Filtered` type's `Subscribe` impl accidentally calls the inner `Filter`'s `on_enter` hook in the `on_exit` hook. This is...obviously wrong, lol, and means that filters like `EnvFilter` will never consider spans to have exited, breaking filtering behavior. @tfreiberg-fastly originally noticed this bug (see #1983 (comment)), but I wanted to make the change separately from PR #1983 so that we can fix it on the main branch without waiting for #1983 to merge first. ## Solution This branch, uh, you know... fixes that.
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…kio-rs#2018) ## Motivation Currently, the `Filtered` type's `Layer` impl accidentally calls the inner `Filter`'s `on_enter` hook in the `on_exit` hook. This is...obviously wrong, lol, and means that filters like `EnvFilter` will never consider spans to have exited, breaking filtering behavior. @tfreiberg-fastly originally noticed this bug (see tokio-rs#1983 (comment)), but I wanted to make the change separately from PR tokio-rs#1983 so that we can fix it on the main branch without waiting for tokio-rs#1983 to merge first. ## Solution This branch, uh, you know... fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
Filteredtype'sLayerimpl accidentally calls theinner
Filter'son_enterhook in theon_exithook. Thisis...obviously wrong, lol, and means that filters like
EnvFilterwillnever consider spans to have exited, breaking filtering behavior.
@tfreiberg-fastly originally noticed this bug (see
#1983 (comment)),
but I wanted to make the change separately from PR #1983 so that we can
fix it on the main branch without waiting for #1983 to merge first.
Solution
This branch, uh, you know... fixes that.