Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appender: prepare to release 0.2.2 #1997

Merged
merged 4 commits into from
Mar 17, 2022
Merged

Conversation

davidbarsky
Copy link
Member

0.2.2 (March 17, 2022)

This release fixes an incorrect compare_exchange in RollingFileAppender
when rolling files over, causing a panic.

Fixed

  • rolling: Fixed a panic that prohibited rolling files over. (#1989)

@davidbarsky davidbarsky requested review from a team, jtescher, yaahc, hawkw and carllerche as code owners March 17, 2022 17:40
@davidbarsky davidbarsky changed the base branch from master to v0.1.x March 17, 2022 17:40
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure to also update the version number here

[crates-url]: https://crates.io/crates/tracing-appender/0.2.1
[docs-badge]: https://docs.rs/tracing-appender/badge.svg
[docs-url]: https://docs.rs/tracing-appender/0.2.1

and here
#![doc(html_root_url = "https://docs.rs/tracing-appender/0.2.1")]

please!

tracing-appender/CHANGELOG.md Outdated Show resolved Hide resolved
tracing-appender/CHANGELOG.md Outdated Show resolved Hide resolved
@davidbarsky
Copy link
Member Author

whoops, sorry about missing some of those! your phrasing suggestions on the changelog are much better—I pulled details from the PR fixing it, but didn't fully understand all the details.

@davidbarsky davidbarsky requested a review from hawkw March 17, 2022 17:51
@hawkw hawkw enabled auto-merge (squash) March 17, 2022 18:27
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this looks good to me --- we can ignore the CI failure on nightly, that's still because nightly ICEs.

@hawkw hawkw merged commit b37d0d3 into v0.1.x Mar 17, 2022
@hawkw hawkw deleted the david/this-is-how-you-get-the-release branch March 17, 2022 18:27
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.2.2 (March 17, 2022)

This release fixes an incorrect `compare_exchange` in RollingFileAppender 
when rolling files over, causing a panic.

### Fixed
- **rolling**: Fixed a panic that prohibited rolling files over. ([tokio-rs#1989])

[tokio-rs#1989]: tokio-rs#1989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants