-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appender: bump MSRV to 1.53.0 #1851
Conversation
The `time` crate bumped its MSRV to 1.53.0 in v0.3.6: time-rs/time@2d37c01 Since `tracing-appender` has a non-optional dependency on `time`, it's necessary to increase its MSRV to track this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems reasonable to me. out of curiosity, does subscriber need to have an MSRV bump? https://github.com/tokio-rs/tracing/blob/v0.1.x/tracing-subscriber/Cargo.toml#L23 I'm guessing no, since it's an off-by-default feaure.
|
The `time` crate bumped its MSRV to 1.53.0 in v0.3.6: time-rs/time@2d37c01 Since `tracing-appender` has a non-optional dependency on `time`, it's necessary to increase its MSRV to track this.
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851]) - `parking_lot`: updated to v0.12 ([#1878]) ### Fixed - Fixed several documentation typos and issues ([#1780], [d868054], [#1943]) [#1760]: #1760 [#1851]: #1851 [#1878]: #1878 [#1943]: #1943 [d868054]: d868054
# 0.2.1 (February 28, 2022) This release adds an implementation of the `MakeWriter` trait for `RollingFileAppender`, allowing it to be used without wrapping in a `NonBlocking` writer. This release increases the minimum supported Rust version to 1.53.0. ### Added - **rolling**: Added `MakeWriter` implementation for `RollingFileAppender` ([tokio-rs#1760]) ### Changed - Updated minimum supported Rust version (MSRV) to 1.53.0 ([tokio-rs#1851]) - `parking_lot`: updated to v0.12 ([tokio-rs#1878]) ### Fixed - Fixed several documentation typos and issues ([tokio-rs#1780], [d868054], [tokio-rs#1943]) [tokio-rs#1760]: tokio-rs#1760 [tokio-rs#1851]: tokio-rs#1851 [tokio-rs#1878]: tokio-rs#1878 [tokio-rs#1943]: tokio-rs#1943 [d868054]: tokio-rs@d868054
The
time
crate bumped its MSRV to 1.53.0 in v0.3.6:time-rs/time@2d37c01
Since
tracing-appender
has a non-optional dependency ontime
, it'snecessary to increase its MSRV to track this.