Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appender: bump MSRV to 1.53.0 #1851

Merged
merged 1 commit into from
Jan 21, 2022
Merged

appender: bump MSRV to 1.53.0 #1851

merged 1 commit into from
Jan 21, 2022

Conversation

hawkw
Copy link
Member

@hawkw hawkw commented Jan 21, 2022

The time crate bumped its MSRV to 1.53.0 in v0.3.6:
time-rs/time@2d37c01

Since tracing-appender has a non-optional dependency on time, it's
necessary to increase its MSRV to track this.

The `time` crate bumped its MSRV to 1.53.0 in v0.3.6:
time-rs/time@2d37c01

Since `tracing-appender` has a non-optional dependency on `time`, it's
necessary to increase its MSRV to track this.
@hawkw hawkw requested review from davidbarsky and a team as code owners January 21, 2022 20:31
Copy link
Member

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems reasonable to me. out of curiosity, does subscriber need to have an MSRV bump? https://github.com/tokio-rs/tracing/blob/v0.1.x/tracing-subscriber/Cargo.toml#L23 I'm guessing no, since it's an off-by-default feaure.

@hawkw
Copy link
Member Author

hawkw commented Jan 21, 2022

this seems reasonable to me. out of curiosity, does subscriber need to have an MSRV bump? https://github.com/tokio-rs/tracing/blob/v0.1.x/tracing-subscriber/Cargo.toml#L23 I'm guessing no, since it's an off-by-default feaure.

tracing-subscriber's dependency on time is an optional feature, while tracing-appender's time dependency is required. Feature flags that enable optional support for an external crate are always considered to have the higher MSRV of the tracing crate and the external crate.

@hawkw hawkw merged commit 5e01d65 into master Jan 21, 2022
@hawkw hawkw deleted the eliza/bump-msrv-appender branch January 21, 2022 20:46
hawkw added a commit that referenced this pull request Jan 21, 2022
The `time` crate bumped its MSRV to 1.53.0 in v0.3.6:
time-rs/time@2d37c01

Since `tracing-appender` has a non-optional dependency on `time`, it's
necessary to increase its MSRV to track this.
hawkw added a commit that referenced this pull request Feb 28, 2022
# 0.2.1 (February 28, 2022)

This release adds an implementation of the `MakeWriter` trait for
`RollingFileAppender`, allowing it to be used without wrapping in a
`NonBlocking` writer.

This release increases the minimum supported Rust version to 1.53.0.

### Added

- **rolling**: Added `MakeWriter` implementation for
  `RollingFileAppender` ([#1760])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851])
- `parking_lot`: updated to v0.12 ([#1878])

### Fixed

- Fixed several documentation typos and issues ([#1780], [d868054],
  [#1943])

[#1760]: #1760
[#1851]: #1851
[#1878]: #1878
[#1943]: #1943
[d868054]: d868054
hawkw added a commit that referenced this pull request Feb 28, 2022
# 0.2.1 (February 28, 2022)

This release adds an implementation of the `MakeWriter` trait for
`RollingFileAppender`, allowing it to be used without wrapping in a
`NonBlocking` writer.

This release increases the minimum supported Rust version to 1.53.0.

### Added

- **rolling**: Added `MakeWriter` implementation for
  `RollingFileAppender` ([#1760])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851])
- `parking_lot`: updated to v0.12 ([#1878])

### Fixed

- Fixed several documentation typos and issues ([#1780], [d868054],
  [#1943])

[#1760]: #1760
[#1851]: #1851
[#1878]: #1878
[#1943]: #1943
[d868054]: d868054
hawkw added a commit that referenced this pull request Feb 28, 2022
# 0.2.1 (February 28, 2022)

This release adds an implementation of the `MakeWriter` trait for
`RollingFileAppender`, allowing it to be used without wrapping in a
`NonBlocking` writer.

This release increases the minimum supported Rust version to 1.53.0.

### Added

- **rolling**: Added `MakeWriter` implementation for
  `RollingFileAppender` ([#1760])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.53.0 ([#1851])
- `parking_lot`: updated to v0.12 ([#1878])

### Fixed

- Fixed several documentation typos and issues ([#1780], [d868054],
  [#1943])

[#1760]: #1760
[#1851]: #1851
[#1878]: #1878
[#1943]: #1943
[d868054]: d868054
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
# 0.2.1 (February 28, 2022)

This release adds an implementation of the `MakeWriter` trait for
`RollingFileAppender`, allowing it to be used without wrapping in a
`NonBlocking` writer.

This release increases the minimum supported Rust version to 1.53.0.

### Added

- **rolling**: Added `MakeWriter` implementation for
  `RollingFileAppender` ([tokio-rs#1760])

### Changed

- Updated minimum supported Rust version (MSRV) to 1.53.0 ([tokio-rs#1851])
- `parking_lot`: updated to v0.12 ([tokio-rs#1878])

### Fixed

- Fixed several documentation typos and issues ([tokio-rs#1780], [d868054],
  [tokio-rs#1943])

[tokio-rs#1760]: tokio-rs#1760
[tokio-rs#1851]: tokio-rs#1851
[tokio-rs#1878]: tokio-rs#1878
[tokio-rs#1943]: tokio-rs#1943
[d868054]: tokio-rs@d868054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants