subscriber: fix missing make_writer_for in BoxMakeWriter
#1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Motivation In `tracing-subscriber` 0.3.x, `MakeWriter` filtering seems to have stopped working when using the `BoxMakeWriter` wrapper to erase the type of a `MakeWriter` implementation. It looks like what happened is that commit 6cc6c47, which backported the change to add a lifetime parameter to `MakeWriter` (#781), I accidentally clobbered the `make_writer_for` method on the inner `Boxed` type, so that it only has `make_writer`: 6cc6c47#diff-c5dc275b15a60c1a2d4694da3797f4247c4f2e1e0978fd210dd14452d6746283L737-L739 This meant that any filtering performed by the `MakeWriter` inside the box is now ignored. My bad! ## Solution This commit puts back the missing `make_writer_for` method. Whoops! Fixes #1694
davidbarsky
approved these changes
Oct 29, 2021
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
…s#1695) ## Motivation In `tracing-subscriber` 0.3.x, `MakeWriter` filtering seems to have stopped working when using the `BoxMakeWriter` wrapper to erase the type of a `MakeWriter` implementation. It looks like what happened is that commit 6cc6c47, which backported the change to add a lifetime parameter to `MakeWriter` (tokio-rs#781), I accidentally clobbered the `make_writer_for` method on the inner `Boxed` type, so that it only has `make_writer`: tokio-rs@6cc6c47#diff-c5dc275b15a60c1a2d4694da3797f4247c4f2e1e0978fd210dd14452d6746283L737-L739 This meant that any filtering performed by the `MakeWriter` inside the box is now ignored. My bad! ## Solution This commit puts back the missing `make_writer_for` method. Whoops! Fixes tokio-rs#1694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In
tracing-subscriber0.3.x,MakeWriterfiltering seems to havestopped working when using the
BoxMakeWriterwrapper to erase the typeof a
MakeWriterimplementation. It looks like what happened is thatcommit 6cc6c47, which backported the
change to add a lifetime parameter to
MakeWriter(#781), Iaccidentally clobbered the
make_writer_formethod on the innerBoxedtype, so that it only has
make_writer:6cc6c47#diff-c5dc275b15a60c1a2d4694da3797f4247c4f2e1e0978fd210dd14452d6746283L737-L739
This meant that any filtering performed by the
MakeWriterinside thebox is now ignored. My bad!
Solution
This commit puts back the missing
make_writer_formethod. Whoops!Fixes #1694