Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: log level filter with trace #1543

Merged
merged 2 commits into from
Sep 11, 2021
Merged

fix: log level filter with trace #1543

merged 2 commits into from
Sep 11, 2021

Conversation

Millione
Copy link
Contributor

@Millione Millione commented Sep 9, 2021 •
edited
Loading

The LogTracer::init() will convert all logs to tracing events, and regardless of the tracing Collector filter, just dispatch all events, cause inconsistent behavior between log and trace.

@Millione Millione requested review from davidbarsky, hawkw and a team as code owners September 9, 2021 05:30
@hawkw hawkw merged commit 5fdbcbf into tokio-rs:master Sep 11, 2021
hawkw added a commit that referenced this pull request Sep 11, 2021
@Millione @hawkw
log: fix LogTracer not honoring max level filters (#1543)
ffbf878 
Co-authored-by: Eliza Weisman <[email protected]>
@hawkw hawkw mentioned this pull request Sep 11, 2021
Merged
hawkw added a commit that referenced this pull request Sep 11, 2021
@Millione @hawkw
log: fix LogTracer not honoring max level filters (#1543)
0ab63ef 
Co-authored-by: Eliza Weisman <[email protected]>
facebook-github-bot pushed a commit to facebook/fb303 that referenced this pull request Sep 15, 2021
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
f652015 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot pushed a commit to facebook/fbthrift that referenced this pull request Sep 15, 2021
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
4a5d933 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot pushed a commit to facebookexperimental/rust-shed that referenced this pull request Sep 15, 2021
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
2526d47 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot pushed a commit to facebookincubator/antlir that referenced this pull request Sep 15, 2021
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
23221b2 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
facebook-github-bot pushed a commit to facebook/sapling that referenced this pull request Sep 15, 2021
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
113060b 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
hawkw added a commit that referenced this pull request Apr 21, 2022
@hawkw
log: prepare to release v0.1.3
3eafee2 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([#1543])
- Broken links in documentation ([#2068], [#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[#2077]: https://github.com/tokio-rs/tracing/pulls/2077
hawkw added a commit that referenced this pull request Apr 21, 2022
@hawkw
log: prepare to release v0.1.3 (#2086)
cdbd122 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([#1543])
- Broken links in documentation ([#2068], [#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[#2077]: https://github.com/tokio-rs/tracing/pulls/2077

Fixes #1884
Fixes #1664
vkill pushed a commit to bk-rs/fbthrift-git-rs that referenced this pull request Jan 12, 2023
@jsgf @facebook-github-bot
third-party/rust: bump all the tracing packages
45a39bc 
Summary:
This includes recent changes:
- `skip_all` in #[instrument] tokio-rs/tracing#1548
- NoSubscriber no-op Subscriber tokio-rs/tracing#1549
- Box/Arc Layer (tokio-rs/tracing#1536 +
  tokio-rs/tracing#1547)
- log filtering fixes tokio-rs/tracing#1543

Local: force `log` and `log-always` features off. This removes the
`enable-trace-logging` flag from smartplatform/reconciler.

Reviewed By: guswynn

Differential Revision: D30906032

fbshipit-source-id: fdc3e4e29a39e9e181d9f4ff017e6b3e16acdcd8
@davidbarsky davidbarsky mentioned this pull request Sep 26, 2023
Merged
kaffarell pushed a commit to kaffarell/tracing that referenced this pull request May 22, 2024
@hawkw @kaffarell
log: prepare to release v0.1.3 (tokio-rs#2086)
f04ba10 
# 0.1.3 (April 21st, 2022)

### Added

- **log-tracer**: Added `LogTracer::with_interest_cache` to enable a
 limited form of per-record `Interest` caching for `log` records
 ([tokio-rs#1636])

### Changed

- Updated minimum supported Rust version (MSRV) to Rust 1.49.0 ([tokio-rs#1913])

### Fixed

- **log-tracer**: Fixed `LogTracer` not honoring `tracing` max level
  filters ([tokio-rs#1543])
- Broken links in documentation ([tokio-rs#2068], [tokio-rs#2077])

Thanks to @Millione, @teozkr, @koute, @Folyd, and @ben0x539 for
contributing to this release!

[tokio-rs#1636]: https://github.com/tokio-rs/tracing/pulls/1636
[tokio-rs#1913]: https://github.com/tokio-rs/tracing/pulls/1913
[tokio-rs#1543]: https://github.com/tokio-rs/tracing/pulls/1543
[tokio-rs#2068]: https://github.com/tokio-rs/tracing/pulls/2068
[tokio-rs#2077]: https://github.com/tokio-rs/tracing/pulls/2077

Fixes tokio-rs#1884
Fixes tokio-rs#1664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw approved these changes

@davidbarsky davidbarsky Awaiting requested review from davidbarsky davidbarsky is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Millione @hawkw