Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscriber: Add a Layer type for composing subscribers #136

Merged
merged 35 commits into from
Jul 17, 2019
Merged

subscriber: Add a Layer type for composing subscribers #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
6da6639
add `Layer` trait for composing subscribers
hawkw Jun 15, 2019
80597c8
WIP first pass on filter layers
hawkw Jun 17, 2019
508d507
post repo move fixup
hawkw Jul 2, 2019
709f04f
rename filter::Layer -> Filter
hawkw Jul 2, 2019
4cbe3c9
add filter combinators
hawkw Jul 2, 2019
dd3f0f1
fix conflicting impls
hawkw Jul 2, 2019
8f065c5
subscriber: Add context type to `Layer`
hawkw Jul 9, 2019
4c93468
fix potential conflicting impls for `Filter`
hawkw Jul 9, 2019
55425b7
re-seal FilterExt
hawkw Jul 9, 2019
fe39cc6
rustfmt
hawkw Jul 9, 2019
ebfe4f0
subscriber: remove ref-counting from Layer (#149)
hawkw Jul 9, 2019
f40fe14
rename `Ctx` -> `Context`
hawkw Jul 9, 2019
1ef8755
path dep EVERYTHING
hawkw Jul 9, 2019
8ec5d1d
subscriber: clarify callbackiness of layer methods
hawkw Jul 10, 2019
d827713
(wip) docs
hawkw Jul 10, 2019
b70189c
add docs to `Layer`
hawkw Jul 10, 2019
93d5981
make chaining layers more natural
hawkw Jul 10, 2019
903810c
fix path deps
hawkw Jul 12, 2019
ef1978a
rustfmt
hawkw Jul 12, 2019
95afd76
cleanup
hawkw Jul 12, 2019
0f52ff3
Apply suggestions from code review
hawkw Jul 15, 2019
55622e9
remove accidentally committed code
hawkw Jul 15, 2019
04e3320
docs review feedback
hawkw Jul 15, 2019
3914071
ensure a Context always refers to a Subscriber
hawkw Jul 15, 2019
dfb5eca
add tests asserting things are subscribers
hawkw Jul 15, 2019
fd416f8
determine filters top-down rather than bottom up
hawkw Jul 15, 2019
04ab3aa
add test for layer downcasting
hawkw Jul 15, 2019
58dcfa6
fix downcasting not forwarding to every layer
hawkw Jul 15, 2019
df1ab62
ensure the whole stack is downcastable
hawkw Jul 15, 2019
3ed0459
fix unused warning
hawkw Jul 15, 2019
2db8436
remove filter trait from this branch
hawkw Jul 15, 2019
6753cad
call out `Context` type in the layer docs
hawkw Jul 17, 2019
fe3d567
improve documentation on filtering with Layer
hawkw Jul 17, 2019
d20eedc
fix broken link
hawkw Jul 17, 2019
19a338a
moar links
hawkw Jul 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tracing-fmt/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ lock_api = "0.1"
chrono = { version = "0.4", optional = true }

[dev-dependencies]
tracing = "0.1"
tracing = { version = "0.1", path = "../tracing" }
2 changes: 1 addition & 1 deletion tracing-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ authors = ["Eliza Weisman <[email protected]>"]
edition = "2018"

[dependencies]
tracing = "0.1"
tracing = { version = "0.1", path = "../tracing" }

[dev-dependencies]
tracing-log = { path = "../tracing-log" }
Expand Down
2 changes: 1 addition & 1 deletion tracing-proc-macros/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ authors = ["Eliza Weisman <[email protected]>", "David Barsky <[email protected]
proc-macro = true

[dependencies]
tracing = "0.1"
tracing = { version = "0.1", path = "../tracing" }
syn = { version = "0.15", features = ["full", "extra-traits"] }
quote = "0.6"
proc-macro2 = { version = "0.4", features = ["nightly"] }
Expand Down
3 changes: 2 additions & 1 deletion tracing-subscriber/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ authors = ["Eliza Weisman <[email protected]>"]
edition = "2018"

[dependencies]
tracing = "0.1"
tracing-core = "0.1.2"

[dev-dependencies]
tracing-log = { path = "../tracing-log" }
tracing = "0.1"
Loading