Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't check examples on MSRV #1128

Merged
merged 2 commits into from
Dec 8, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
uses: actions-rs/cargo@v1
with:
command: check
args: --all --bins --examples --tests --benches
args: --all --bins --tests --benches

cargo-hack:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
rust: [stable, beta, nightly, 1.42.0]
rust: [stable, beta, nightly]
steps:
- uses: actions/checkout@main
- uses: actions-rs/toolchain@v1
Expand All @@ -128,6 +128,32 @@ jobs:
command: test
args: --all

test-msrv:
# Test against the minimum supported Rust version
needs: check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@main
- uses: actions-rs/toolchain@v1
with:
toolchain: 1.42.0
profile: minimal
override: true
# We can't use `cargo test --all`, as that will also compile the examples.
# We don't guarantee the examples will work on the MSRV, because they have
# external dependencies which may not comply with our MSRV policy, but don't
# actually impact users on our MSRV.
- name: Run tests
uses: actions-rs/cargo@v1
with:
command: test
args: --workspace --lib --tests
- name: Run doctests
uses: actions-rs/cargo@v1
with:
command: test
args: --workspace --doc

test-build-wasm:
needs: check
runs-on: ubuntu-latest
Expand Down