-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #1012 #1014
Merged
Merged
Backport #1012 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for having dashes in log target names, like: `target-name=info`
hawkw
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
I'll update the crate version & changelog when I do the release (momentarily). Thanks for asking, though! |
hawkw
added a commit
that referenced
this pull request
Oct 7, 2020
Changed - Updated `tracing-core` to 0.1.17 ([#992]) Added - **env-filter**: Added support for filtering on targets which contain dashes ([#1014]) - **env-filter**: Added a warning when creating an `EnvFilter` that contains directives that would enable a level disabled by the `tracing` crate's `static_max_level` features ([#1021]) Thanks to @jyn514 and @bkchr for contributing to this release! [#992]: #992 [#1014]: #1014 [#1021]: #1021
hawkw
added a commit
that referenced
this pull request
Oct 7, 2020
Changed - Updated `tracing-core` to 0.1.17 ([#992]) Added - **env-filter**: Added support for filtering on targets which contain dashes ([#1014]) - **env-filter**: Added a warning when creating an `EnvFilter` that contains directives that would enable a level disabled by the `tracing` crate's `static_max_level` features ([#1021]) Thanks to @jyn514 and @bkchr for contributing to this release! [#992]: #992 [#1014]: #1014 [#1021]: #1021
hawkw
added a commit
that referenced
this pull request
Oct 7, 2020
### Changed - Updated `tracing-core` to 0.1.17 ([#992]) ### Added - **env-filter**: Added support for filtering on targets which contain dashes ([#1014]) - **env-filter**: Added a warning when creating an `EnvFilter` that contains directives that would enable a level disabled by the `tracing` crate's `static_max_level` features ([#1021]) Thanks to @jyn514 and @bkchr for contributing to this release! [#992]: #992 [#1014]: #1014 [#1021]: #1021
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
### Changed - Updated `tracing-core` to 0.1.17 ([tokio-rs#992]) ### Added - **env-filter**: Added support for filtering on targets which contain dashes ([tokio-rs#1014]) - **env-filter**: Added a warning when creating an `EnvFilter` that contains directives that would enable a level disabled by the `tracing` crate's `static_max_level` features ([tokio-rs#1021]) Thanks to @jyn514 and @bkchr for contributing to this release! [tokio-rs#992]: tokio-rs#992 [tokio-rs#1014]: tokio-rs#1014 [tokio-rs#1021]: tokio-rs#1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports: #1012
@hawkw should I directly bump the crate version?