Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - warning header styles not loaded #2444

Closed
rwakulszowa opened this issue Jan 14, 2023 · 0 comments · Fixed by #2449
Closed

Documentation - warning header styles not loaded #2444

rwakulszowa opened this issue Jan 14, 2023 · 0 comments · Fixed by #2449

Comments

@rwakulszowa
Copy link
Contributor

https://tracing.rs/tracing/

The documentation looks like this:
image

Half of the page is covered by the warning header. From what I can see, rustdoc adds the necessary css file to the root folder (i.e., it creates a theme.css file), while the actual website tries to find it under static.files/theme.css.

I am definitely not an expert here, but, from what I've tried, you can solve the problem by using html-in-header instead of extend-css. The extra CSS can be wrapped in a <style> tag, making it a perfectly valid HTML to include in the header:

... --html-in-header assets/warning.css --html-in-header assets/noindex.html ...

I can send a PR, but let me know if there's a better way.

Side note

It pains me to see the actual CSS content, even after the fix, rendered on a mobile screen, but that's a separate problem.

@hawkw hawkw closed this as completed in 2ace0b5 Feb 8, 2023
davidbarsky pushed a commit that referenced this issue Sep 27, 2023
The documentation under https://tracing.rs/tracing/ is missing CSS
styles. Fixes #2444

Used the `--html-in-header` rustdoc flag instead of `--extend-css`.
Converted the css file into an html file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant