tracing subscriber has a lot of default features #1258
Labels
crate/subscriber
Related to the `tracing-subscriber` crate
meta/breaking
This is a breaking change, and should wait until the next breaking release.
Milestone
Comments
|
I think it's definitely worth reconsidering this as part of the Tracing 0.2 work — for the next breaking change, I think we may want to factor out all of the subscriber implementations into a separate crate from the core trait definitions. |
hawkw
added
crate/subscriber
hawkw
added a commit
that referenced
this issue
Oct 18, 2021
This changes `tracing-subscriber` so that the `env-filter`, `json`, and `chrono` features are not enabled by default, and instead require users to opt in. This should significantly reduce the default dependency footprint. Of course, this is a breaking change, and therefore will be part of `tracing-subscriber` v0.3. Fixes #1258 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this issue
Oct 18, 2021
This changes `tracing-subscriber` so that the `env-filter`, `json`, and `chrono` features are not enabled by default, and instead require users to opt in. This should significantly reduce the default dependency footprint. Of course, this is a breaking change, and therefore will be part of `tracing-subscriber` v0.3. Fixes #1258 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this issue
Oct 21, 2021
This changes `tracing-subscriber` so that the `env-filter`, `json`, and `chrono` features are not enabled by default, and instead require users to opt in. This should significantly reduce the default dependency footprint. Of course, this is a breaking change, and therefore will be part of `tracing-subscriber` v0.3. Fixes #1258 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this issue
Oct 21, 2021
This changes `tracing-subscriber` so that the `env-filter`, `json`, and `chrono` features are not enabled by default, and instead require users to opt in. This should significantly reduce the default dependency footprint. Of course, this is a breaking change, and therefore will be part of `tracing-subscriber` v0.3. Fixes #1258 Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I see that
tracing-subscriberhas a lot default features. This feels a bit wrong to me: I understand that this is the crate which should be used by libraries implementing subscribers. Ie, it's an intermediate library. In this context, authors of subscribers might forget to includedefault-features = false, and induce deps on final consumers. See rust-lang/chalk#686 (comment) for an example of this.I wonder if maybe this is wrong crate factoring? Maybe
subscribershould be just acfged non-default module of thetracingcrate?Super unclear about what's the best solution here, but it's definitely a problem that rust-analyzer pulls in chrono, and I need to investigate which of my dependencies done this :)
The text was updated successfully, but these errors were encountered: