subscriber: fix buggy format with module disabled (#481)

Closes #476
tokio-rs · Dec 20, 2019 · e930f05 · e930f05
1 parent 11dab1e
commit e930f05
Showing 1 changed file with 8 additions and 22 deletions.
diff --git a/tracing-subscriber/src/fmt/format/mod.rs b/tracing-subscriber/src/fmt/format/mod.rs
@@ -256,17 +256,10 @@ where
             }
         };
 
-        write!(
-            writer,
-            "{} {}{}: ",
-            fmt_level,
-            full_ctx,
-            if self.display_target {
-                meta.target()
-            } else {
-                ""
-            }
-        )?;
+        write!(writer, "{} {}", fmt_level, full_ctx)?;
+        if self.display_target {
+            write!(writer, "{}: ", meta.target())?;
+        }
         ctx.format_fields(writer, event)?;
         writeln!(writer)
     }
@@ -308,17 +301,10 @@ where
                 (FmtLevel::new(meta.level()), FmtCtx::new(&ctx))
             }
         };
-        write!(
-            writer,
-            "{} {}{}: ",
-            fmt_level,
-            fmt_ctx,
-            if self.display_target {
-                meta.target()
-            } else {
-                ""
-            }
-        )?;
+        write!(writer, "{} {}", fmt_level, fmt_ctx)?;
+        if self.display_target {
+            write!(writer, "{}:", meta.target())?;
+        }
         ctx.format_fields(writer, event)?;
         let span = ctx.ctx.current_span();
         if let Some(id) = span.id() {