trace: Span API polish #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In practice, there wasn't really a use-case for this, and it complicates the implementation. We can always add it back later. Signed-off-by: Eliza Weisman <[email protected]>'
Again, there wasn't actually a use-case for spans with metadata that doesn't live for the static lifetime, and it made using `Span`s in other types somewhat more challenging. It's also possible to implement an alternative API for non-static spans on top of the `tokio-trace-core` primitives. Signed-off-by: Eliza Weisman <[email protected]>
LucioFranco
approved these changes
Mar 18, 2019
| @@ -154,18 +142,11 @@ use { | |||
| /// span will silently do nothing. Thus, the handle can be used in the same | |||
| /// manner regardless of whether or not the trace is currently being collected. | |||
| #[derive(Clone, PartialEq, Hash)] | |||
| pub struct Span<'a> { | |||
| pub struct Span { | |||
There was a problem hiding this comment.
this means we can drop the lifetime from tokio_trace_futures::Instrumented?
There was a problem hiding this comment.
Yes; in fact, this will break the current Instrumented.
There was a problem hiding this comment.
Works for me! its an easy upgrade
hawkw
added a commit
to tokio-rs/tracing
that referenced
this pull request
Mar 19, 2019
hawkw
added a commit
to tokio-rs/tracing
that referenced
this pull request
Mar 20, 2019
tokio-rs/tokio#988 removed the generic lifetime parameter from `Span`. This branch updates the nursery crates to match. Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 25, 2019
This branch makes the following changes to `tokio-trace`'s `Span` type: * **Remove manual close API from spans** In practice, there wasn't really a use-case for this, and it complicates the implementation a bit. We can always add it back later. * **Remove generic lifetime from `Span`** Again, there wasn't actually a use-case for spans with metadata that doesn't live for the static lifetime, and it made using `Span`s in other types somewhat inconvenient. It's also possible to implement an alternative API for non-static spans on top of the `tokio-trace-core` primitives. Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes the following changes to
tokio-trace'sSpantype:Remove manual close API from spans
In practice, there wasn't really a use-case for this, and it
complicates the implementation a bit. We can always add it back later.
Remove generic lifetime from
SpanAgain, there wasn't actually a use-case for spans with metadata that
doesn't live for the static lifetime, and it made using
Spans inother types somewhat inconvenient. It's also possible to implement an
alternative API for non-static spans on top of the
tokio-trace-coreprimitives.
Signed-off-by: Eliza Weisman [email protected]