Try and force Windows Server 2016 for AppVeyor builds. #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Toby Lawrence <[email protected]>
carllerche
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Occasionally,
tokio-tlstests on AppVeyor (CI platform for running on Windows) fail with aThe buffers supplied to a function was too smallerror. Searching points to a bug deep within the WindowsSChannelframework itself (whichtokio-tlsuses due to being based onnative-tlswhich prefers OS-native SSL/TLS libraries) that was only fixed in Windows 10/Windows Server 2016:https://github.com/dotnet/corefx/issues/31611#issuecomment-410792235
https://github.com/dotnet/corefx/issues/7812#issuecomment-305848835
Solution
I believe we should able to avoid to avoid these spurious failures by running all Windows builds on Server 2016. Unfortunately, due to the spurious nature of the bug, we can't really test this easily.. but we can ensure that we're at least running on Server 2016 which should theoretically resolve the issue.
Signed-off-by: Toby Lawrence [email protected]