Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio-test: mark tokio_test::task::Spawn as must_use #6371

Merged
merged 1 commit into from
Mar 4, 2024
Merged

tokio-test: mark tokio_test::task::Spawn as must_use #6371

merged 1 commit into from
Mar 4, 2024

Conversation

mox692
Copy link
Member

@mox692 mox692 commented Feb 29, 2024

A task passed to Spawn will not be executed unless it is polled, and it would be more helpful to add must_use annotation.

Darksonn
Darksonn approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Good call.

@Darksonn Darksonn merged commit f6d0619 into tokio-rs:master Mar 4, 2024
75 checks passed
@Darksonn Darksonn added A-tokio-test Area: The tokio-test crate M-task Module: tokio/task labels Mar 4, 2024
@mox692 mox692 deleted the mark_spawn_must_use branch March 4, 2024 16:13
@Darksonn Darksonn mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-test Area: The tokio-test crate M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mox692 @Darksonn