chore: update rust-version to 1.63 in all crates #6126
Conversation
Darksonn
added
A-tokio-util
| @@ -6,7 +6,7 @@ name = "tokio-macros" | |||
| # - Create "tokio-macros-1.x.y" git tag. | |||
| version = "2.1.0" | |||
| edition = "2021" | |||
| rust-version = "1.56" | |||
| rust-version = "1.63" | |||
There was a problem hiding this comment.
tokio-macros is a dependency of tokio, so I don't think it is a utility crate.
There was a problem hiding this comment.
Good point. I'll reword the commit message when I merge it. However, I don't see any issue in upgrading it, since the next release of tokio-macros will need at least the next version of Tokio, which is on 1.63.
Darksonn
changed the title
Cargo uses cargo-hack's |
|
Ah, wow it supports that? Cargo-hack is awesome. |
| @@ -6,7 +6,7 @@ name = "tokio-util" | |||
| # - Create "tokio-util-0.7.x" git tag. | |||
| version = "0.7.10" | |||
| edition = "2021" | |||
| rust-version = "1.56" | |||
| rust-version = "1.63" | |||
There was a problem hiding this comment.
Just to clarify, is this no longer accurately representing the minimal version this would compile on? As the issue I raised mentioned it was (EDIT: I had forgotten about changes to 1.60 with an older tokio release.0.7.10 bumping it again)
I understand with newer tokio releases that 1.56 isn't supported, and the current 1.56 for tokio-util is already inaccurate as a fallback for toolchains below 1.60.
So is rust-version within tokio crates likely not to represent a crates actual minimal toolchain version to compile on? But the MSRV for tokio crates as a whole?
EDIT: My bad, I forgot that a newer release of tokio-util also bumped to hashbrown 0.14 which has rust-version = "1.63" 🤦♂️
Refs: #6125