Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::io::Seek for tokio_util::io::SyncIoBridge #6058

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Implement std::io::Seek for tokio_util::io::SyncIoBridge #6058

merged 1 commit into from
Oct 7, 2023

Conversation

nitsky
Copy link
Contributor

@nitsky nitsky commented Oct 7, 2023

Motivation

I want to use a type that implements AsyncSeek with sync code.

Solution

This PR implements std::io::Seek for tokio_util::io::SyncIoBridge.

@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-io Module: tokio/io labels Oct 7, 2023
Darksonn
Darksonn approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@Darksonn Darksonn merged commit 4557451 into tokio-rs:master Oct 7, 2023
73 checks passed
@satakuma satakuma mentioned this pull request Oct 8, 2023
Merged
@Darksonn Darksonn mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate M-io Module: tokio/io
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitsky @Darksonn