Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poll: Do not clear readiness on short read/writes. #5881

Merged
merged 2 commits into from
Jul 19, 2023
Merged

poll: Do not clear readiness on short read/writes. #5881

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c12e17
poll: Do not clear readiness on short read/writes.
jasta Jul 18, 2023
b50ef0e
Leave a note about the mio_unsupported_force_poll_poll gotchas for ev…
jasta Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tokio/src/io/poll_evented.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ feature! {
Ok(n) => {
// if we read a partially full buffer, this is sufficient on unix to show
// that the socket buffer has been drained
if n > 0 && (!cfg!(windows) && n < len) {
if n > 0 && (!cfg!(windows) && !cfg!(mio_unsupported_force_poll_poll) && n < len) {
jasta marked this conversation as resolved.
Show resolved Hide resolved
self.registration.clear_readiness(evt);
}

Expand Down Expand Up @@ -197,7 +197,7 @@ feature! {
Ok(n) => {
// if we write only part of our buffer, this is sufficient on unix to show
// that the socket buffer is full
if n > 0 && (!cfg!(windows) && n < buf.len()) {
if n > 0 && (!cfg!(windows) && !cfg!(mio_unsupported_force_poll_poll) && n < buf.len()) {
self.registration.clear_readiness(evt);
}

Expand Down