rt: use optional non-zero value for task owner_id
#5876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We switch to using a `NonZeroU64` for the `id` field for `OwnedTasks` and `LocalOwnedTasks` lists. This allows the task header to contain an `Option<NonZeroU64>` instead of a `u64` with a special meaning for 0. The size in memory will be the same thanks to Rust's niche optimization, but this solution is clearer in its intent.
Darksonn
reviewed
Jul 17, 2023
Darksonn
added
A-tokio
Darksonn
reviewed
Jul 17, 2023
Co-authored-by: Alice Ryhl <[email protected]>
Co-authored-by: Alice Ryhl <[email protected]>
- add comments when exiting early from (Local)OwnedTasks::remove - set_owner_id no longer takes an Option - comment corrections
Merged
Darksonn
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switch to using a
NonZeroU64for theidfield forOwnedTasksand
LocalOwnedTaskslists. This allows the task header to contain anOption<NonZeroU64>instead of au64with a special meaning for 0.The size in memory will be the same thanks to Rust's niche optimization,
but this solution is clearer in its intent.