fs: Add File::options() assoc function to mimic std
#5869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Jul 16, 2023
tokio/src/fs/file.rs
Outdated
| @@ -199,6 +195,37 @@ impl File { | |||
| Ok(File::from_std(std_file)) | |||
| } | |||
|
|
|||
| /// Returns a new OpenOptions object. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns a new OpenOptions object. | |
| /// Returns a new [`OpenOptions`] object. |
tokio/src/fs/file.rs
Outdated
| @@ -199,6 +195,37 @@ impl File { | |||
| Ok(File::from_std(std_file)) | |||
| } | |||
|
|
|||
| /// Returns a new OpenOptions object. | |||
| /// | |||
| /// This function returns a new OpenOptions object that you can use to | |||
There was a problem hiding this comment.
Suggested change
| /// This function returns a new OpenOptions object that you can use to | |
| /// This function returns a new `OpenOptions` object that you can use to |
Darksonn
reviewed
Jul 16, 2023
tokio/src/fs/file.rs
Outdated
| /// | ||
| /// # async fn dox() -> std::io::Result<()> { | ||
| /// let mut f = File::options().append(true).open("example.log").await?; | ||
| /// f.write_all(b"new line").await?; |
There was a problem hiding this comment.
If we're appending a line, then we should write a newline.
Suggested change
| /// f.write_all(b"new line").await?; | |
| /// f.write_all(b"new line\n").await?; |
There was a problem hiding this comment.
My bad, it was writeln!() in std.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found myself
std::fs::Files::options()function really convenient and I accidentally typed it in tokio project. Hey, it would be an easy PR chance, right?Code is copied from std with minor modifications, including docs explaining its motivation.