Use a dynamic buffer in the AsyncReadExt's read_exact example
#5863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: https://stackoverflow.com/questions/68979882/readread-exact-does-not-fill-buffer In most cases when `read_exact` is used the user doesn't know beforehand how many bytes are gonna be read. This leads to code like `Vec::with_capacity(len)` when really what the user wants is `vec![0; len]` (the former has a length of zero so it succeeds with `Ok(0)`.
Darksonn
approved these changes
Jul 16, 2023
Darksonn
added
T-docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See this SO question.
In most cases when
read_exactis used the user doesn't know beforehand how many bytes are gonna be read. This leads to code likeVec::with_capacity(len)when really what the user wants isvec).Solution
Change the example to use the
vec!macro instead of a fixed-sized array. This will make adding a warning obsolete.