-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokio test mock wait #5554
Merged
Merged
Tokio test mock wait #5554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wait(): test timing the read() test with an additional `Wait` action - multiple_wait(): test timing the read() test with two additional `Wait` actions ! multiple_wait() fails
Clear `waiting` after completion of the current wait allowing subsequent waits to be registered before they were being discarded
Darksonn
added
A-tokio-test
Area: The tokio-test crate
M-time
Module: tokio/time
labels
Mar 18, 2023
Darksonn
reviewed
Mar 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR. I have an improvement to your test, but otherwise it looks good.
Darksonn
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear
waiting
after completion of the current wait allowing subsequent waits to be registered instead of being discarded.Motivation
The
Mock
intokio-test::io
won't work properly with multipleAction::Wait()
actions.Example using
Builder::wait()
The first commit in this PR includes two tests regarding the
wait
issue, one of whichmultiple_wait
is equivalent to the example above and fails without the fix introduced in the second commit of this PRSolution
The
waiting
option onInner
was set on the firstAction::Wait()
but never cleared, causing subsequentAction::Wait()
to be discarded because the value ofwaiting
was already in the past.The fix clears
self.waiting
when the wait has finished