net: fix named pipe connect

[satakuma]

Closes: #5170

[Darksonn]

Can you please make sure that we have a test for both inbound = false and inbound = true, since this seems to be causing trouble?

[satakuma]

I added a test with different inbound/outbound access settings. It fails (hangs) both on master and with my previous, flawed solution.

[Darksonn]

We can't have tests that depend on timing. They are brittle, and make the test suite take a long time. 10 ms sleeps add up to seconds surprisingly quickly if you have lots of tests.

You can do something like this:

let (tx, rx) = tokio::sync::oneshot::channel();
let server = tokio::spawn(async move {
    let s = ServerOptions::new()
        .access_inbound(inb)
        .access_outbound(outb)
        .create(PIPE_NAME)?;

    let mut connect_fut = tokio_test::task::spawn(s.connect());
    assert!(connect_fut.poll().is_pending());

    let _ = tx.send(());

    connect_fut.await.unwrap();
});

// Wait for the server to call connect.
rx.await.unwrap();
let _ = ClientOptions::new().read(outb).write(inb).open(PIPE_NAME)?;

[satakuma]

Sure!

[Darksonn]

Thanks.