rt: rm internal Unpark types for Handle types
#5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
added
C-maintenance
Base automatically changed from
split-driver-unpark-from-mt-parker
to
master
September 17, 2022 23:46
This patch removes all internal `Unpark` runtime types. The runtime now uses the `Handle` types (`runtime::io::Handle` and `runtime::time::Handle`) to signal threads to unpark. Without separate `Unpark` types, future patches will be able to remove more `Arc`s used inside various drivers.
carllerche
force-pushed
the
rm-driver-unpark
branch
from
0c9a50e to
af3fd33
Compare
Noah-Kennedy
approved these changes
Sep 18, 2022
dbischof90
pushed a commit
to dbischof90/tokio
that referenced
this pull request
Oct 1, 2022
This patch removes all internal `Unpark` runtime types. The runtime now uses the `Handle` types (`runtime::io::Handle` and `runtime::time::Handle`) to signal threads to unpark. Without separate `Unpark` types, future patches will be able to remove more `Arc`s used inside various drivers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes all internal
Unparkruntime types. The runtime now uses theHandletypes (runtime::io::Handleandruntime::time::Handle) to signal threads to unpark.Without separate
Unparktypes, future patches will be able to remove moreArcs used inside various drivers.This depends on #5026