[draft] io: consume budget in Registration::readiness #4784
Conversation
Noah-Kennedy
changed the title
Darksonn
added
A-tokio
|
This seems like it might make some operations consume budget twice. |
Noah-Kennedy
changed the title
Noah-Kennedy
changed the title
|
Yes, I don't think this is actually where I want to put this. |
|
I'll finish this up in the morning, I'm a bit too sleepy to figure out where best to put it right now. |
|
@Darksonn I'm not actually sure where something we have could consume budget twice for the same work. Also, is there any general guidelines for where should consume budget (which operations is it worthwhile for) or not? I was looking through where all we do budgeting vs don't and it doesn't seem super consistent to me. |
|
The CI failures I think have to do with tests assuming that something will always immediately yield |
|
Generally, we consume one budget whenever a poll function returns |
| Pin::new(&mut fut).poll(cx).map(Ok) | ||
| let x = Pin::new(&mut fut).poll(cx).map(Ok); | ||
|
|
||
| coop.made_progress(); |
There was a problem hiding this comment.
| coop.made_progress(); | |
| if x.is_ready() { | |
| coop.made_progress(); | |
| } |
|
@Noah-Kennedy do you have time to finish this up? If not, would you like me to take it over? |
|
I should be able to finish this up on Saturday. If you can get to this before then, go for it! |
|
Since this is a stale draft, I will close it for now. |
Fixes #4782.