-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm32-wasi target support #4716
Changes from all commits
d41ba97
4acce7f
6ade965
3b6cf09
af6a351
aeedf12
4c0cf30
eb92668
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,6 +29,7 @@ cfg_codec! { | |
} | ||
|
||
cfg_net! { | ||
#[cfg(not(target_arch = "wasm32"))] | ||
pub mod udp; | ||
pub mod net; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -778,6 +778,7 @@ async fn compact_change_deadline() { | |
assert!(entry.is_none()); | ||
} | ||
|
||
#[cfg_attr(target_os = "wasi", ignore = "FIXME: Does not seem to work with WASI")] | ||
#[tokio::test(start_paused = true)] | ||
async fn remove_after_compact() { | ||
let now = Instant::now(); | ||
Comment on lines
+781
to
784
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's weird. Do we know why? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because it uses There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay. In that case, ignoring this test is fine, but the ignore label should explain that this is due to catching panics. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Many of the tests disabled for Wasi just have There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Prefer using ignore, but that doesn't always work because it might call methods that are missing. In that case just use |
||
|
@@ -794,6 +795,7 @@ async fn remove_after_compact() { | |
assert!(panic.is_err()); | ||
} | ||
|
||
#[cfg_attr(target_os = "wasi", ignore = "FIXME: Does not seem to work with WASI")] | ||
#[tokio::test(start_paused = true)] | ||
async fn remove_after_compact_poll() { | ||
let now = Instant::now(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK w/ this for now, but maybe we can open a tracking issue to remove this? The test itself doesn't look like it needs thread spawning. I'm not exactly sure why it is the way it is.