- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: mark JoinHandle as UnwindSafe (#4414) #4418
Merged
Darksonn
merged 2 commits into
tokio-rs:master
from
Hodkinson:mark_joinhandle_unwindsafe
Jan 24, 2022
+9
−0
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
runtime: mark JoinHandle as UnwindSafe (#4414)
commit debbbb7989b7abc1b703d2ffbc2d0ce7fa733286
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,22 @@ | |
#![cfg(feature = "full")] | ||
|
||
use std::panic::{RefUnwindSafe, UnwindSafe}; | ||
use tokio::task::spawn_blocking; | ||
|
||
#[tokio::test] | ||
async fn futures_are_unwind_safe() { | ||
unwind_safe_future(|| async { | ||
let _ = spawn_blocking(|| {}).await; | ||
}) | ||
.await | ||
} | ||
|
||
async fn unwind_safe_future<F, Fut>(_: F) | ||
where | ||
F: FnOnce() -> Fut, | ||
Fut: std::future::Future<Output = ()> + std::panic::UnwindSafe, | ||
{ | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's a pretty convoluted way to test this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I agree, I altered it to test the actual change 🙂 |
||
|
||
#[test] | ||
fn net_types_are_unwind_safe() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should it not be unwind safe when
T
isn'tSend
?