Add into_mutex_reference for MutexGuard #3741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2021
|
Going to close this for now. See the changes to #3742 that makes this pull request unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to build a condition variable (#2739) in tokio there needs to be a way to release the lock and get a reference to the underlying Mutex.
One way to do this would be to pass both the MutexGuard and a reference to the Mutex to
Condvar::waitbut that would differ from the API instd:sync.Solution
This pull request adds a single function
MutexGuard::into_mutex_reference(suggestions for a better name are welcome). The method consumes theMutexGuardobject, releases the underlying lock and returns a reference to theMutex.