process: allow for ergonomically piping stdio of one child into another #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `TryInto<Stdio>` impls for `ChildStd{in,out,err}` for ergonomic
conversions into `std::process::Stdio` so callers can perform the
conversion without needing to manipulate raw fds/handles directly
ipetkov
added
A-tokio
Co-authored-by: Alice Ryhl <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
Turns out the tests were catching a subtle bug, namely, not resetting the Requesting a re-review for the new logic that was added! |
Darksonn
reviewed
Jan 25, 2021
Comment on lines
+182
to
+186
| // Ensure that the fd to be inherited is set to *blocking* mode, as this | ||
| // is the default that virtually all programs expect to have. Those | ||
| // programs that know how to work with nonblocking stdio will know how to | ||
| // change it to nonblocking mode. | ||
| set_nonblocking(&mut fd, false)?; |
There was a problem hiding this comment.
So this is ok because neither end of the pipe is actually used in Tokio?
There was a problem hiding this comment.
Correct. One end of the pipe should be owned by the child process (and already closed in the parent). The other end of the pipe is moved into this function, and calling .into_inner() unwraps the PollEvented and deregisters it from the reactor.
Darksonn
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TryInto<Stdio>impls forChildStd{in,out,err}for ergonomicconversions into
std::process::Stdioso callers can perform theconversion without needing to manipulate raw fds/handles directly
Fixes #3465