Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: remove path deps #3413

Merged
merged 6 commits into from
Jan 12, 2021
Merged

util: remove path deps #3413

merged 6 commits into from
Jan 12, 2021

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 12, 2021

No description provided.

@taiki-e taiki-e added the A-ci Area: The continuous integration setup label Jan 12, 2021
@taiki-e taiki-e mentioned this pull request Jan 12, 2021
Merged
@taiki-e taiki-e marked this pull request as draft January 12, 2021 13:22
@taiki-e taiki-e changed the title ci: run clippy with --all-features util: remove path deps Jan 12, 2021
@taiki-e
Copy link
Member Author

taiki-e commented Jan 12, 2021

Ok, I think I fixed all "remove path deps"-related errors that @Darksonn encountered in #3402.

@taiki-e taiki-e marked this pull request as ready for review January 12, 2021 14:32
@taiki-e taiki-e requested a review from Darksonn January 12, 2021 14:32
Darksonn
Darksonn approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If clippy has no further complaints, then this looks good to me.

@taiki-e taiki-e added the A-tokio-util Area: The tokio-util crate label Jan 12, 2021
@taiki-e
Copy link
Member Author

taiki-e commented Jan 12, 2021

Running nightly clippy gives me some warnings that break code if accepting the suggestion, but in MSRV it's fine.

@taiki-e taiki-e merged commit d37486d into tokio-rs:master Jan 12, 2021
@taiki-e taiki-e deleted the clippy branch January 12, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-ci Area: The continuous integration setup A-tokio-util Area: The tokio-util crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taiki-e @Darksonn