Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builder: disable io and timer running w/ miri #3392

Closed
wants to merge 2 commits into from
Closed

builder: disable io and timer running w/ miri #3392

wants to merge 2 commits into from

Conversation

blasrodri
Copy link
Contributor

Fixes: #3360

Motivation

Solution

@Kestrer Kestrer mentioned this pull request Jan 8, 2021
Open
@carllerche
Copy link
Member

Per @RalfJung (#3360 (comment)) the Miri cfg does not sound like it is intended to be used by libs.

I am inclined to not make this change.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Jan 9, 2021
@Darksonn
Copy link
Contributor

Darksonn commented Jan 9, 2021

Yeah, I agree with not doing this.

@Darksonn Darksonn closed this Jan 9, 2021
@blasrodri blasrodri deleted the io-timer-disabled-on-miri branch January 9, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't start the reactor when running Miri
3 participants
@blasrodri @carllerche @Darksonn