Upgrade tokio-util to bytes 0.6 #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use poll_read_buf() implementations from tokio proper.
2 tasks
taiki-e
approved these changes
Oct 27, 2020
| @@ -7,7 +7,7 @@ name = "tokio-util" | |||
| # - Cargo.toml | |||
| # - Update CHANGELOG.md. | |||
| # - Create "v0.2.x" git tag. | |||
| version = "0.4.0" | |||
| version = "0.5.0" | |||
There was a problem hiding this comment.
It may be preferable to split this (bump crate version) into separate PRs (but personally either is fine).
There was a problem hiding this comment.
Mm, we will need a release preparation PR in any case.
carllerche
added a commit
that referenced
this pull request
Oct 27, 2020
This reverts commit fe2b997.
carllerche
added a commit
that referenced
this pull request
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Would like to use tokio-util with the latest bytes release (which tokio-0.3 now also depends on).
Solution
In order to make this work, it seems to be required to move
poll_read_buf()intoAsyncReadExtrather than duplicating it in tokio-util. This actually seems helpful too, so looks like a win-win to me.