Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: write sync mod API docs #2175

Merged
merged 4 commits into from
Jan 27, 2020
Merged

docs: write sync mod API docs #2175

merged 4 commits into from
Jan 27, 2020

Conversation

carllerche
Copy link
Member

This includes some expected use cases for the various sync primitives.

Darksonn
Darksonn approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Note that this appears to solve #2171. The CI also appears to be unhappy with your links.

tokio/src/sync/mod.rs Outdated Show resolved Hide resolved
tokio/src/sync/mod.rs Outdated Show resolved Hide resolved
@carllerche carllerche mentioned this pull request Jan 26, 2020
Closed
@carllerche
Copy link
Member Author

I'm breaking out bumping nightly into #2178.

@carllerche carllerche merged commit bcba4aa into master Jan 27, 2020
@carllerche carllerche deleted the sync-docs branch February 1, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

@ultrasaurus ultrasaurus Awaiting requested review from ultrasaurus

@LucioFranco LucioFranco Awaiting requested review from LucioFranco

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carllerche @Darksonn