default all feature flags to off #1811
Conversation
Changes the set of `default` feature flags to `[]`. By default, only core traits are included without specifying feature flags. This makes it easier for users to pick the components they need. For convenience, a `full` feature flag is included that includes all components. Tests are configured to require the `full` feature. Testing individual feature flags will need to be moved to a separate crate. Closes #1791
|
README.md structure: ### Tokio for Applications
`tokio = { version = "0.2, features = ["full"] }`
### Tokio for Libraries
`tokio = { version = "0.2, features = ["features"] }`Each of the features should be pretty-well documented. |
Co-Authored-By: Taiki Endo <[email protected]>
azure-pipelines.yml
Outdated
| @@ -3,6 +3,7 @@ pr: ["master"] | |||
|
|
|||
| variables: | |||
| RUSTFLAGS: -Dwarnings | |||
| nightly: 2019-11-16 | |||
There was a problem hiding this comment.
Why are we now pinning the nightly?
| @@ -1,5 +1,6 @@ | |||
| #![cfg(unix)] | |||
| #![cfg(feature = "full")] | |||
There was a problem hiding this comment.
This line should be moved down by one to be consistent with all the others.
| @@ -0,0 +1,19 @@ | |||
| macro_rules! cfg_codec { | |||
There was a problem hiding this comment.
Why does tokio-util need these helpers when none of the other crates (afaict) do?
There was a problem hiding this comment.
tokio needs the helpers too?
There was a problem hiding this comment.
TBH, tokio-util is kind of under developed ATM. We may want it to be tokio-codec 🤷
|
Hi! I'd like to ask you to revise this decision. It looks like it brings more problems for newcomers than benefits for powerusers (#1833). Cargo already has a tool for disabling default features: |
|
Having frequented both the user's forum and this issue tracker, this is not something people ask about often. Adding it to the Libraries depending on too many features of other libraries is incredibly common for projects with several default features. |
|
Thank you for the clarification! I don't like the idea of fixing other libraries by putting obstacles for a quick start, but good documentation will really help to resolve this problem. Everyone would learn about feature flags at some point in time. It won't hurt if Tokio is the crate that requires this knowledge. |
Changes the set of
defaultfeature flags to[]. By default, onlycore traits are included without specifying feature flags. This makes it
easier for users to pick the components they need.
For convenience, a
fullfeature flag is included that includes allcomponents.
Tests are configured to require the
fullfeature. Testing individualfeature flags will need to be moved to a separate crate.
Closes #1791