Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io: remove unsafe pin-projections and remove manual Unpin implementations #1588

Merged
merged 7 commits into from
Sep 24, 2019
Merged

io: remove unsafe pin-projections and remove manual Unpin implementations #1588

merged 7 commits into from
Sep 24, 2019

Commits on Sep 22, 2019

  1. chore: update pin-project to 0.4.0-beta.1

    @taiki-e
    taiki-e committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    212b92f View commit details
    Browse the repository at this point in the history

  2. Make pin-project optional dependency

    @taiki-e
    taiki-e committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    817c66d View commit details
    Browse the repository at this point in the history

  3. io: remove unsafe pin-projections

    @taiki-e
    taiki-e committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    7c62968 View commit details
    Browse the repository at this point in the history

  4. io: remove manual Unpin implementations and add assertions 

    As references always implement Unpin, there is no need to implement
Unpin manually.

Also, changing Unpin requirements will be breaking changes, so add tests
to check for Unpin requirements.
    @taiki-e
    taiki-e committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    6cf9068 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into io-safe-pin-projection

    @taiki-e
    taiki-e committed Sep 22, 2019
    Configuration menu
    Copy the full SHA
    5ee4dbf View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. remove non-related changes

    @taiki-e
    taiki-e committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    d678e9b View commit details
    Browse the repository at this point in the history

  2. #[cfg(test)] mod tests

    @taiki-e
    taiki-e committed Sep 23, 2019
    Configuration menu
    Copy the full SHA
    7efa9c7 View commit details
    Browse the repository at this point in the history