Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join! and try_join! deadlock with empty invocation #5502

Closed
adrianheine opened this issue Feb 23, 2023 · 0 comments · Fixed by #5504
Closed

join! and try_join! deadlock with empty invocation #5502

adrianheine opened this issue Feb 23, 2023 · 0 comments · Fixed by #5504
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-macros Module: macros in the main Tokio crate

Comments

@adrianheine
Copy link
Contributor

Version
Starting with 1.19.0 (i. e. everything including 1872a42 / #4624).

Platform
any

Description
join!() and try_join!() emit an empty loop {}, see playground. I would expect this to either work (preferred) or be rejected at compile time (acceptable).
@adrianheine adrianheine added A-tokio Area: The main tokio crate C-bug Category: This is a bug. labels Feb 23, 2023
@Darksonn Darksonn added the M-macros Module: macros in the main Tokio crate label Feb 23, 2023
adrianheine added a commit to adrianheine/tokio that referenced this issue Feb 25, 2023
@adrianheine
tokio: Fix empty join! and try_join!
a72bfe2 
This closes tokio-rs#5502.
adrianheine added a commit to adrianheine/tokio that referenced this issue Feb 25, 2023
@adrianheine
tokio: Fix empty join! and try_join!
0b8be26 
This closes tokio-rs#5502.
adrianheine added a commit to adrianheine/tokio that referenced this issue Feb 25, 2023
@adrianheine
fix empty join! and try_join!
f28bdfa 
Fixes: tokio-rs#5502
@adrianheine adrianheine mentioned this issue Feb 25, 2023
Merged
adrianheine added a commit to adrianheine/tokio that referenced this issue Feb 25, 2023
@adrianheine
fix empty join! and try_join!
e9d9ff3 
Fixes: tokio-rs#5502
Darksonn pushed a commit that referenced this issue Feb 25, 2023
@adrianheine
macros: fix empty join! and try_join! (#5504)
ca9f7ee 
Fixes: #5502
amab8901 pushed a commit to amab8901/tokio that referenced this issue Feb 27, 2023
@adrianheine @amab8901
macros: fix empty join! and try_join! (tokio-rs#5504)
cff1f10 
Fixes: tokio-rs#5502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate C-bug Category: This is a bug. M-macros Module: macros in the main Tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix empty join! and try_join! adrianheine/tokio
2 participants
@adrianheine @Darksonn