Check for space in frame_buf #161
Conversation
| @@ -304,7 +304,9 @@ impl<T> Multiplex<T> where T: Dispatch { | |||
| while self.run { | |||
| // TODO: Only read frames if there is available space in the frame | |||
| // buffer | |||
| if let Async::Ready(frame) = try!(self.dispatch.get_mut().inner.transport().poll()) { | |||
| if self.frame_buf.full() { | |||
There was a problem hiding this comment.
It's been a while since I dealt with this code. When the frame_buf has capacity again, something has to notify the task so that it starts running again. Could you explain how this happens?
There was a problem hiding this comment.
I have to admit I'm not as familiar with some of the inner workings as I would like, but this is how it works as far as I can tell. If the buffer is at capacity that necessarily means that there is data to flush. If the flush needs to block that is when the task will be parked. Once the flush is finished the task will start running again. If the flush did not need to block then the task will continue running through another loop of dispatch, read, write, flush.
There was a problem hiding this comment.
This is plausible... a test would help confirm it :)
There was a problem hiding this comment.
I'll have to figure out how to write a small test that can trigger a filled buffer case consistently. I was able to trigger it on a large project of mine but that doesn't readily translate to a good unit test.
There was a problem hiding this comment.
As I suspected, writing a small test that can consistently trigger this edge case is far from trivial. I'm in the middle of finals right now so I will not be able to get around to writing a unit test for this for a week or so
|
Well that's odd, the commits I squashed together came back. I'll have to go back and fix that now. |
Closes #143